"quite right, they are quite obviously an entirely martial society."

Obviously not entirely. And it's a bit unfortunate they aren't as extreme as the Spartans. They just have a much harder life than humans do, and it results in being better at combat.

"funny how that doesn't tie in with the peace loving shamistic society they claim to have been before the legion came along or the peace wanting shamistic society they are trying to claim they are now eh ?"

Um. How doesn't it? The orcs are tricked by demons into considering the draenei evil heretics, and gear up for war, and then wage war for many years. They obviously get pretty good at it. Also, obviously, they have an ever-increasing population of shamans, and dwindling population of warlocks.
So yeah. They used to be peace-loving, and want to be again. The fact that in the meantime they eke out an exist in Kalimdor and are required to be rather rough-and-ready doesn't change that at all.

"in Lord of the Clans Thrall makes quite clear he doesnt want to engage the Alliance in open war because he knows the Horde would lose but hey you believe whatever you want."

In Lord of the Clans, Thrall is young and has just broken free from captivity, and probably thinks humans won't let him and his kind live free.
He definitely doesn't want war now, for any reason. He's all shamany and diplomatic and whatnot. Tell yourself that he wouldn't lift a finger to help the Alliance if he could avoid it without consequence, and you'll be dead, completely wrong.

"so i'm just wasting my time."

You're wasting my time if you're choosing to interpret the actions and thoughts of young Thrall at one specific point in his life with the actions and thoughts of old Thrall.